-
Notifications
You must be signed in to change notification settings - Fork 227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. We'll need those ARM images published first. I'll talk with the etcd team about that.
@crawford Did you want to rename I can do that in this PR, or make another. |
Seems like a reasonable idea. I'd be fine with it in a separate commit in this PR. |
Added patch |
Rebased to lastest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this. A few minor tweaks, and this looks good.
amd64? ( | ||
app-admin/etcd-wrapper | ||
) | ||
app-admin/etcd-wrapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coreos
ebuild revision number should probably be bumped for this. (The symlink in the same directory.) Maybe the coreos-base/coreos
changes could be in their own commit.
@@ -22,8 +22,15 @@ RDEPEND=">=app-emulation/rkt-1.9.1[rkt_stage1_fly]" | |||
S=${WORKDIR} | |||
|
|||
src_install() { | |||
local tag="v3.1.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the ebuild has the same version now, maybe make this value "v${PV}"
so updates only require a rename with no edits.
Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Geoff Levand <geoff@infradead.org>
Used |
Also adds missing ebuild metadata.
Same ebuild structure as #2511 (Reenable flannel on arm64).
To work as-is on arm64 the etcd-wrapper needs etcd-io/etcd#7714 and an arm64 release to quay.io/coreos/etcd.
For testing, a systemd drop-in
/etc/systemd/system/etcd-member.service.d/local.conf
with something like this should work: